enter_title_here filter causing issues

Replies: 0

Hi Hal
I’m a plugin developer myself and I’m just reporting a small bug.

You have the filter

add_filter( 'enter_title_here', 'register_testimonial_form_title' );

Which loads this function:

/* TITLE INPUT FOR TESTIMONIALS */
function register_testimonial_form_title( $title )
{
     $screen = get_current_screen();
     if  ( $screen->post_type == 'testimonial' ) 
     {
          return __('Enter Highlight Here', 'testimonial-rotator');
     }
}

As you can see above, it doesn’t return the default value, it only returns something if you’re in the edit screen of your custom post type. So all other filters added to the enter_title_here hook will fail.

Would you consider updating the code to fix this issue? Something like:

/* TITLE INPUT FOR TESTIMONIALS */
function register_testimonial_form_title( $title )
{
     $screen = get_current_screen();
     if  ( $screen->post_type == 'testimonial' ) 
     {
          return __('Enter Highlight Here', 'testimonial-rotator');
     }
     return $title;
}

Cheers, Carlos